LITE-23321: Adding owner data to product on get_products #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3rky
suggested changes
Aug 9, 2023
connect_ext_ppr/service.py
Outdated
| @@ -127,6 +127,7 @@ def add_deployments(installation, listings, config, logger): | |||
|
|
|||
|
|
|||
| def process_ppr_from_product_update(data, config, context, client, logger): | |||
| logger.error("NEW data arrived") | |||
There was a problem hiding this comment.
[COD-C] Are sure to log the info as an ERROR?
connect_ext_ppr/utils.py
Outdated
| @@ -87,6 +89,10 @@ def get_hubs(client, hubs_ids): | |||
| return client.hubs.filter(rql) | |||
|
|
|||
|
|
|||
| def get_partners(client, account_ids): | |||
There was a problem hiding this comment.
[COD-C] It will not work for the syndication products, since there is no way to know the vendor. Why you don't want to extract that information from the product itself? I think it contains owner id and name
There was a problem hiding this comment.
Or even store in DB the owner also? Just two plain fields
akodelia
force-pushed
the
feature/LITE-28321-Add-owner-data-into-get-product-response
branch
from
33ecd93
to
fe8b495
Compare
akodelia
force-pushed
the
feature/LITE-28321-Add-owner-data-into-get-product-response
branch
from
fe8b495
to
a35e3d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.