Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fixed create issue #65

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat: fixed create issue #65

merged 1 commit into from
Jan 16, 2024

Conversation

theprashantyadav
Copy link
Contributor

what

  • added user_group_ids to in aws_elasticache_replication_group resource

why

  • need to fixed create issue

@theprashantyadav theprashantyadav requested a review from a team January 15, 2024 14:11
@clouddrove-ci clouddrove-ci self-assigned this Jan 15, 2024
@theprashantyadav theprashantyadav mentioned this pull request Jan 15, 2024
Closed
h1manshu98
h1manshu98 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themaniskshah
themaniskshah approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@themaniskshah themaniskshah merged commit 78ef6ce into master Jan 16, 2024
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/issue-1 branch January 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h1manshu98 h1manshu98 h1manshu98 approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

@mamrajyadav mamrajyadav Awaiting requested review from mamrajyadav

@d4kverma d4kverma Awaiting requested review from d4kverma

@vaibhav7797 vaibhav7797 Awaiting requested review from vaibhav7797

@nileshgadgi nileshgadgi Awaiting requested review from nileshgadgi

Assignees

@theprashantyadav theprashantyadav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theprashantyadav @themaniskshah @h1manshu98 @clouddrove-ci @anmolnagpal