Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/count condition #17

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Fix/count condition #17

merged 5 commits into from
Feb 14, 2024

Conversation

Rupalgw
Copy link
Contributor

@Rupalgw Rupalgw commented Feb 14, 2024

what

  • Test each module when the enable variable is true.
  • Deploy the module, then set the enable variable to false, ensuring all resources are destroyed without errors.

why

  • the changes being made due to error in count condition

@Rupalgw Rupalgw added the enhancement New feature or request label Feb 14, 2024
@Rupalgw Rupalgw requested review from 13archit and d4kverma February 14, 2024 11:32
@Rupalgw Rupalgw self-assigned this Feb 14, 2024
d4kverma
d4kverma approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@d4kverma d4kverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4kverma d4kverma merged commit 315005a into master Feb 14, 2024
12 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/count_condition branch February 14, 2024 16:10
@d4kverma d4kverma mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4kverma d4kverma d4kverma approved these changes

@13archit 13archit Awaiting requested review from 13archit

Assignees

@Rupalgw Rupalgw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rupalgw @d4kverma