Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm-bindgen-maro issue. #248

Merged

Conversation

ozabalaferrera
Copy link
Contributor

This fixes the build issue caused by rustwasm/wasm-bindgen#4304
@smoelius helped me troubleshoot this, see previous try here ozabalaferrera#2 (comment)

Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Copy link
Member

@Lazzaretti Lazzaretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks a lot!

@Lazzaretti Lazzaretti merged commit 897cd85 into cloudevents:main Dec 3, 2024
10 checks passed
@ozabalaferrera
Copy link
Contributor Author

No problem! If it is alright with you and the rest of the team, I'll keep contributing to help out however I can. I'll keep an eye on the issues, but let me know if I can help with any specific features or priority issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants