Skip to content

Commit

Permalink
CESQL v1 review changes (#1286)
Browse files Browse the repository at this point in the history
* clarify integer overflow behaviour, order of evaluation

Signed-off-by: Calum Murray <[email protected]>

* Address feedback from @duglin

* Link to ISO 9075
* Fix some typos
* Clarify return types and errors
* Simplify ebnf definitions for value identifiers
* Clarify type casting and behaviour for operators

Signed-off-by: Calum Murray <[email protected]>

* further fixes from review by @duglin

Signed-off-by: Calum Murray <[email protected]>

* clarify error handling and zero values

Signed-off-by: Calum Murray <[email protected]>

* further clarify error handling and zero values

Signed-off-by: Calum Murray <[email protected]>

* parenthized -> paranthesized

Signed-off-by: Calum Murray <[email protected]>

* more fixes from review by @duglin

Signed-off-by: Calum Murray <[email protected]>

* fix the should verification problem

Signed-off-by: Calum Murray <[email protected]>

* clarify default type of attributes

Signed-off-by: Calum Murray <[email protected]>

* fix indentation of operator precedence

Signed-off-by: Calum Murray <[email protected]>

* it's -> its

Signed-off-by: Calum Murray <[email protected]>

---------

Signed-off-by: Calum Murray <[email protected]>
  • Loading branch information
Cali0707 authored May 30, 2024
1 parent 66c067b commit e30acf3
Showing 1 changed file with 132 additions and 78 deletions.
Loading

0 comments on commit e30acf3

Please sign in to comment.