Clean up contributors.md #1303
Merged
Clean up contributors.md #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Klaus Deißner <[email protected]>
markpeek
approved these changes
Jul 10, 2024
|
LGTM thanks! |
jskeet
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
LGTM modulo the blank lines.
Is Jeremy Coffield (currently no link) https://github.com/plfx? Seems likely. I haven't looked into the other link-less names.
Signed-off-by: Klaus Deißner <[email protected]>
|
I removed the empty lines at the end. Yes, there were a few names without links. I did not try to add links to avoid confusion. If somebody provides the correct github links, I will add them. |
|
Thanks for bringing this whole issue to my attention @devguyio ! 😄 |
I think that's reasonable. I guess if folks want to be linked, they can create their own PRs :) |
Cali0707
reviewed
Jul 18, 2024
Co-authored-by: Calum Murray <[email protected]> Signed-off-by: Klaus Deißner <[email protected]>
|
Approved on the 7/18 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided in the weekly call, I removed the company names and put the names in alphabetical order.