Feature/update cronjob name #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shagamemnon |
|
Thanks @Anticmos. Can you please create a default string value for the # deploy.sh
CRON_JOB_NAME='cf_logs_cron' |
|
@shagamemnon Any updates on this? |
z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As I was making use of this project I ran into a case where if I ran the deploy twice it would not always overwrite the previous CRON job and I also did not have enough control over the name of the cron job for subsequent runs.
This can cause confusion as GCP will just spit out:
ERROR: (gcloud.scheduler.jobs.create.pubsub) ALREADY_EXISTS: Job .../jobs/cf_logs_cron already exists.Please take a look at the addition of a new variable!
Looking forward to feedback.
Thanks!