Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare): Remove zone_id and zone_name in DNSRecord #253

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

woshiluo
Copy link
Contributor

@woshiluo woshiluo commented Feb 2, 2025

As https://developers.cloudflare.com/changelog/ said on 27th, Jan, 2025, "Records returned by the API will no longer contain the zone_id and zone_name fields.", so we need to remove it to avoid parse error.

ref #251

As https://developers.cloudflare.com/changelog/ said on 27th, Jan,
2025, "Records returned by the API will no longer contain the zone_id
and zone_name fields.", so we need to remove it to avoid parse error.

Signed-off-by: Woshiluo Luo <[email protected]>
newAM added a commit to newAM/cloudflare-rs that referenced this pull request Feb 2, 2025
newAM added a commit to newAM/cloudflare-rs that referenced this pull request Feb 2, 2025
Copy link

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out, it fixed #251 for me, thanks!

Copy link

@r-birkner r-birkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

Copy link
Collaborator

@kennetheversole kennetheversole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this

@kennetheversole kennetheversole merged commit 7f56e85 into cloudflare:master Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants