Clippy

c-api/src/lib.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::missing_safety_doc)]
+
 pub use crate::streaming::CStreamingHandler;
 use libc::{c_char, c_int, c_void, size_t};
 use lol_html::html_content::*;

c-api/src/rewriter_builder.rs

@@ -58,6 +58,7 @@ pub struct ExternDocumentContentHandlers {
 }
 
 impl ExternDocumentContentHandlers {
+    #[must_use]
     pub fn as_safe_document_content_handlers(&self) -> DocumentContentHandlers {
         let mut handlers = DocumentContentHandlers::default();
 
@@ -77,6 +78,7 @@ pub struct ExternElementContentHandlers {
 }
 
 impl ExternElementContentHandlers {
+    #[must_use]
     pub fn as_safe_element_content_handlers(&self) -> ElementContentHandlers {
         let mut handlers = ElementContentHandlers::default();
 
@@ -100,6 +102,7 @@ pub struct HtmlRewriterBuilder {
 }
 
 impl HtmlRewriterBuilder {
+    #[must_use]
     pub fn get_safe_handlers(&self) -> SafeContentHandlers {
         SafeContentHandlers {
             document: self

c-api/src/streaming.rs

@@ -59,6 +59,7 @@ pub unsafe extern "C" fn lol_html_streaming_sink_write_utf8_chunk(
 }
 
 /// Safety: the user data and the callbacks must be safe to use from a different thread (e.g. can't rely on thread-local storage).
+///
 /// It doesn't have to be `Sync`, it will be used only by one thread at a time.
 ///
 /// Handler functions copy this struct. It can (and should) be created on the stack.

c-api/src/string.rs

@@ -35,7 +35,7 @@ impl Str {
 
 impl Drop for Str {
     fn drop(&mut self) {
-        if self.data == ptr::null() {
+        if self.data.is_null() {
             return;
         }
         let bytes = unsafe { slice::from_raw_parts_mut(self.data.cast_mut(), self.len) };

js-api/src/html_rewriter.rs

@@ -49,12 +49,12 @@ pub struct HTMLRewriter(RewriterState);
 #[wasm_bindgen]
 impl HTMLRewriter {
     #[wasm_bindgen(constructor)]
-    pub fn new(encoding: String, output_sink: &JsFunction) -> JsResult<HTMLRewriter> {
+    pub fn new(encoding: String, output_sink: &JsFunction) -> JsResult<Self> {
         let encoding = Encoding::for_label(encoding.as_bytes())
             .and_then(AsciiCompatibleEncoding::new)
             .ok_or_else(|| JsError::new("Invalid encoding"))?;
 
-        Ok(HTMLRewriter(RewriterState::Before {
+        Ok(Self(RewriterState::Before {
             output_sink: JsOutputSink::new(output_sink),
             settings: Settings {
                 encoding,