Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-api: use cargo-c #247

Merged
merged 1 commit into from
Dec 5, 2024
Merged

c-api: use cargo-c #247

merged 1 commit into from
Dec 5, 2024

Conversation

selfisekai
Copy link
Contributor

No description provided.

@selfisekai
Copy link
Contributor Author

The generated header differs a lot from the removed one for some reason

@kornelski
Copy link
Contributor

kornelski commented Dec 5, 2024

I've had the same issue with cargo-c. I think by default it wants to generate a new header using cbindgen. Our hand-written header is much better.

You can use this as a template to switch to hand-written header:

https://github.com/ImageOptim/libimagequant/blob/fea449e31038a1aeddf85b768d90426bb3a0411c/imagequant-sys/Cargo.toml#L42C1-L45

@selfisekai selfisekai marked this pull request as ready for review December 5, 2024 15:01
@kornelski kornelski merged commit b906cb9 into cloudflare:master Dec 5, 2024
3 checks passed
@kornelski
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants