Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable exhaustruct linter #1242

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Enable exhaustruct linter #1242

merged 1 commit into from
Jan 3, 2025

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.69.1-31-gefb669e
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Jan 3, 2025

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.50m ± 0%   39.71m ± 1%       ~ (p=0.123 n=10)
CheckRules-4     8.515 ± 2%    8.492 ± 2%       ~ (p=0.280 n=10)
geomean         580.0m        580.7m       +0.13%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=1.000 n=10)
CheckRules-4    977.2Mi ± 0%   978.3Mi ± 0%       ~ (p=0.052 n=10)
geomean         163.6Mi        163.7Mi       +0.06%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.866 n=10)
CheckRules-4    14.15M ± 0%   14.16M ± 0%       ~ (p=0.052 n=10)
geomean         1.365M        1.366M       +0.02%

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 98.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.11%. Comparing base (1f8f627) to head (efb669e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/checks/promql_vector_matching.go 75.00% 1 Missing ⚠️
internal/reporter/gitlab.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
+ Coverage   95.07%   95.11%   +0.03%     
==========================================
  Files         105      105              
  Lines       12644    12599      -45     
==========================================
- Hits        12021    11983      -38     
+ Misses        473      468       -5     
+ Partials      150      148       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive force-pushed the exhaustruct branch 3 times, most recently from 22ea56b to bde8ee0 Compare January 3, 2025 16:11
@prymitive prymitive merged commit 45da6ef into main Jan 3, 2025
20 checks passed
@prymitive prymitive deleted the exhaustruct branch January 3, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants