Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alerts/external_labels check #767

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

prymitive
Copy link
Collaborator

@prymitive prymitive commented Oct 31, 2023

Fixes #531

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.48.2-1-g88c3052
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #767 (88c3052) into main (8a7b01d) will increase coverage by 0.02%.
The diff coverage is 96.73%.

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   94.14%   94.17%   +0.02%     
==========================================
  Files          88       89       +1     
  Lines        8849     8941      +92     
==========================================
+ Hits         8331     8420      +89     
- Misses        393      395       +2     
- Partials      125      126       +1     
Files Coverage Δ
internal/checks/base.go 97.95% <ø> (ø)
internal/config/config.go 98.67% <100.00%> (+0.02%) ⬆️
internal/checks/alerts_external_labels.go 96.55% <96.55%> (ø)

@prymitive prymitive merged commit 4dbe0ab into main Oct 31, 2023
20 checks passed
@prymitive prymitive deleted the alerts/external_labels branch October 31, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More lenient alerts/template rule
2 participants