-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan for all rules when running pint ci #803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request was validated by pint.
✔️ No problems found
Stats
Stat | Value |
---|---|
Version | v0.50.0-23-g2ba76de |
Number of rules parsed | 4 |
Number of rules checked | 0 |
Number of problems found | 0 |
Number of offline checks | 0 |
Number of online checks | 0 |
Checks duration | 0 |
Problems
No problems reported
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
- Coverage 94.14% 93.50% -0.65%
==========================================
Files 92 93 +1
Lines 9743 9947 +204
==========================================
+ Hits 9173 9301 +128
- Misses 433 506 +73
- Partials 137 140 +3 ☔ View full report in Codecov by Sentry. |
b0ad02b
to
a59e0d8
Compare
f8940cf
to
fb880eb
Compare
.github/pint/rules/2.yaml
Outdated
@@ -1,5 +1,5 @@ | |||
groups: | |||
- name: test | |||
rules: | |||
- record: up:sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove the recording rule generating up:sum
, and there is no other source of this metric, then any other rule depending on it will break.
List of found rules that are using up:sum
:
Everything Is Down
at.github/pint/rules/1.yml:12
.github/pint/rules/2.yaml
Outdated
@@ -1,5 +1,3 @@ | |||
groups: | |||
- name: test | |||
rules: | |||
- record: up:sum | |||
expr: sum(up) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove the recording rule generating up:sum
, and there is no other source of this metric, then any other rule depending on it will break.
List of found rules that are using up:sum
:
Everything Is Down
at.github/pint/rules/1.yml:12
No description provided.