Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan for all rules when running pint ci #803

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Scan for all rules when running pint ci #803

merged 5 commits into from
Dec 8, 2023

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.50.0-23-g2ba76de
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (71051b5) 94.14% compared to head (afe067c) 93.50%.

❗ Current head afe067c differs from pull request most recent head 2ba76de. Consider uploading reports for the commit 2ba76de to get more accurate results

Files Patch % Lines
internal/reporter/bitbucket_api.go 46.04% 69 Missing and 6 partials ⚠️
internal/reporter/github.go 50.00% 10 Missing and 2 partials ⚠️
internal/discovery/glob.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   94.14%   93.50%   -0.65%     
==========================================
  Files          92       93       +1     
  Lines        9743     9947     +204     
==========================================
+ Hits         9173     9301     +128     
- Misses        433      506      +73     
- Partials      137      140       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive force-pushed the deps branch 3 times, most recently from b0ad02b to a59e0d8 Compare December 7, 2023 11:40
@prymitive prymitive force-pushed the deps branch 6 times, most recently from f8940cf to fb880eb Compare December 7, 2023 16:16
@cloudflare cloudflare deleted a comment from github-actions bot Dec 7, 2023
@cloudflare cloudflare deleted a comment from github-actions bot Dec 7, 2023
@@ -1,5 +1,5 @@
groups:
- name: test
rules:
- record: up:sum
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ rule/dependency: Metric generated by this rule is used by 1 other rule(s).

If you remove the recording rule generating up:sum, and there is no other source of this metric, then any other rule depending on it will break.
List of found rules that are using up:sum:

  • Everything Is Down at .github/pint/rules/1.yml:12

@@ -1,5 +1,3 @@
groups:
- name: test
rules:
- record: up:sum
expr: sum(up)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ rule/dependency: Metric generated by this rule is used by 1 other rule(s).

If you remove the recording rule generating up:sum, and there is no other source of this metric, then any other rule depending on it will break.
List of found rules that are using up:sum:

  • Everything Is Down at .github/pint/rules/1.yml:12

@prymitive prymitive merged commit 221b78c into main Dec 8, 2023
20 checks passed
@prymitive prymitive deleted the deps branch December 8, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants