Dangling lifetimes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
force-pushed
the
dangling_lifetimes
branch
from
5a24dec
to
8acecdf
Compare
kornelski
force-pushed
the
dangling_lifetimes
branch
from
8acecdf
to
ac8a0b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions like
fn as_bytes<'a>(&self) -> &'a [u8]are dangerous, because Rust can implicitly give'aany lifetime, including'static.For this reason, where it's necessary, I gave it scarier name. In other cases I've used
'_instead, which has a safer default (borrows from the reference arg), and can't become a footgun by forgetting'ain&'a self.I've also used less powerful casts where possible.