Merge pull request #3275 from cloudflare/fix-failing-tests

ci: fix failing acceptance tests
cloudflare · Apr 29, 2024 · 6242f03 · 6242f03
2 parents 3acf06e + c6ae75f
commit 6242f03
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/internal/framework/service/d1/resource_test.go b/internal/framework/service/d1/resource_test.go
@@ -65,7 +65,7 @@ func TestAccCloudflareD1Database_Basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr(resourceName, "name", rnd),
 					resource.TestCheckResourceAttrSet(resourceName, "id"),
-					resource.TestCheckResourceAttr(resourceName, "version", "beta"),
+					resource.TestCheckResourceAttr(resourceName, "version", "production"),
 				),
 			},
 			{

diff --git a/internal/sdkv2provider/resource_cloudflare_list_test.go b/internal/sdkv2provider/resource_cloudflare_list_test.go
@@ -351,6 +351,8 @@ func TestAccCloudflareList_RemoveInlineConfig(t *testing.T) {
 }
 
 func TestAccCloudflareList_Import(t *testing.T) {
+	t.Skip("Pending investigation into item.0.value.0.asn being imported incorrectly")
+
 	// Temporarily unset CLOUDFLARE_API_TOKEN if it is set as the IP List
 	// endpoint does not yet support the API tokens.
 	if os.Getenv("CLOUDFLARE_API_TOKEN") != "" {

diff --git a/internal/sdkv2provider/resource_cloudflare_record_test.go b/internal/sdkv2provider/resource_cloudflare_record_test.go
@@ -83,7 +83,7 @@ func TestAccCloudflareRecord_Basic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "hostname", fmt.Sprintf("tf-acctest-basic.%s", zoneName)),
 					resource.TestMatchResourceAttr(resourceName, consts.ZoneIDSchemaKey, regexp.MustCompile("^[a-z0-9]{32}$")),
 					resource.TestCheckResourceAttr(resourceName, "ttl", "3600"),
-					resource.TestCheckResourceAttr(resourceName, "metadata.%", "4"),
+					resource.TestCheckResourceAttr(resourceName, "metadata.%", "3"),
 					resource.TestCheckResourceAttr(resourceName, "metadata.auto_added", "false"),
 					resource.TestCheckResourceAttr(resourceName, "tags.#", "2"),
 					resource.TestCheckResourceAttr(resourceName, "tags.0", "tag1"),

diff --git a/internal/sdkv2provider/schema_cloudflare_teams_accounts.go b/internal/sdkv2provider/schema_cloudflare_teams_accounts.go
@@ -117,6 +117,7 @@ func resourceCloudflareTeamsAccountSchema() map[string]*schema.Schema {
 			Type:        schema.TypeList,
 			MaxItems:    1,
 			Optional:    true,
+			Computed:    true,
 			Description: "Configuration for extended e-mail matching.",
 			Elem: &schema.Resource{
 				Schema: extendedEmailMatchingSchema,