Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CF list item ID duplication on creation #2849

Conversation

agesta23
Copy link

This PR addresses an issue where multiple cloudflare_list_item resources were assigned the same ID during creation. By refining the logic for determining the item's ID post-creation, we can ensure that each cloudflare_list_item gets its unique and correct ID, thus reflecting its actual state in Cloudflare.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

changelog detected ✅

@github-actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@jacobbednarz
Copy link
Member

thanks for the time you've put into this PR! however, this really needs to be fixed in the service itself otherwise it will be a bug for other list item types and we don't currently have a way to fetch just a single record. there is already work under way for this internally so once that lands, we'll raise a PR to fix this in the provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants