Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix settings the Locations field for client_certificate_v2 posture rules #4168

Merged

Conversation

jlu-cloudflare
Copy link
Contributor

Fixes settings the Locations field for client_certificate_v2 posture rules as well as creates a test for it. The test should be skipped for the default account.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

changelog detected ✅

@jlu-cloudflare jlu-cloudflare force-pushed the fix-client-certificate-v2 branch from b7bc9a8 to b60bee5 Compare October 2, 2024 19:11
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDevicePostureRule_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDevicePostureRule_SerialNumber
--- PASS: TestAccCloudflareDevicePostureRule_SerialNumber (5.40s)
=== RUN   TestAccCloudflareDevicePostureRule_OsVersion
--- PASS: TestAccCloudflareDevicePostureRule_OsVersion (4.36s)
=== RUN   TestAccCloudflareDevicePostureRule_OsVersionExtra
--- PASS: TestAccCloudflareDevicePostureRule_OsVersionExtra (4.74s)
=== RUN   TestAccCloudflareDevicePostureRule_LinuxOsDistro
--- PASS: TestAccCloudflareDevicePostureRule_LinuxOsDistro (4.23s)
=== RUN   TestAccCloudflareDevicePostureRule_DomainJoined
--- PASS: TestAccCloudflareDevicePostureRule_DomainJoined (3.82s)
=== RUN   TestAccCloudflareDevicePostureRule_Firewall
--- PASS: TestAccCloudflareDevicePostureRule_Firewall (4.64s)
=== RUN   TestAccCloudflareDevicePostureRule_DiskEncryption_RequireAll
--- PASS: TestAccCloudflareDevicePostureRule_DiskEncryption_RequireAll (4.07s)
=== RUN   TestAccCloudflareDevicePostureRule_DiskEncryption_CheckDisks
--- PASS: TestAccCloudflareDevicePostureRule_DiskEncryption_CheckDisks (3.77s)
=== RUN   TestAccCloudflareDevicePostureRule_ClientCertificateV2
    provider_test.go:217: Skipping acceptance test for default account (f037e56e89293a057740de681ac9abbe). Assertion requires an active certificate configured
--- SKIP: TestAccCloudflareDevicePostureRule_ClientCertificateV2 (0.00s)
=== RUN   TestAccCloudflareDevicePostureRule_Intune
    provider_test.go:217: Skipping acceptance test for default account (f037e56e89293a057740de681ac9abbe). Assertion requires active Intune license.
--- SKIP: TestAccCloudflareDevicePostureRule_Intune (0.00s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	36.098s

@jacobbednarz jacobbednarz merged commit f391afa into cloudflare:master Oct 8, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.44.0 milestone Oct 8, 2024
Copy link
Contributor

This functionality has been released in v4.44.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants