Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start persisting teams rule settings #4261

Merged

Conversation

rexscaria
Copy link

This fixes gateway rule settings not acting correctly because they were never properly persisted in the state.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

changelog detected ✅

@jacobbednarz
Copy link
Member

looks like we've hit a regression here

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsRule_" -count 1 -timeout 120m -parallel 1

=== RUN   TestAccCloudflareTeamsRule_Basic
--- PASS: TestAccCloudflareTeamsRule_Basic (2.70s)
=== RUN   TestAccCloudflareTeamsRule_NoSettings
    resource_cloudflare_teams_rules_test.go:98: Step 2/2 error: Check failed: Check 8/8 error: cloudflare_zero_trust_gateway_policy.anszqvautt: Attribute 'rule_settings.#' expected "0", got "1"
--- FAIL: TestAccCloudflareTeamsRule_NoSettings (3.20s)
=== RUN   TestAccCloudflareTeamsRule_CustomResolver
--- PASS: TestAccCloudflareTeamsRule_CustomResolver (2.46s)
=== RUN   TestAccCloudflareTeamsRule_WithClipboardRedirection
--- PASS: TestAccCloudflareTeamsRule_WithClipboardRedirection (2.36s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	12.218s
FAIL
make: *** [testacc] Error 1

@rexscaria
Copy link
Author

Updated test. Apologies Thanks

@jacobbednarz
Copy link
Member

nice one

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsRule_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsRule_Basic
--- PASS: TestAccCloudflareTeamsRule_Basic (3.18s)
=== RUN   TestAccCloudflareTeamsRule_NoSettings
--- PASS: TestAccCloudflareTeamsRule_NoSettings (3.18s)
=== RUN   TestAccCloudflareTeamsRule_CustomResolver
--- PASS: TestAccCloudflareTeamsRule_CustomResolver (2.29s)
=== RUN   TestAccCloudflareTeamsRule_WithClipboardRedirection
--- PASS: TestAccCloudflareTeamsRule_WithClipboardRedirection (2.21s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	11.383s

.changelog/4261.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 799a824 into cloudflare:master Oct 11, 2024
7 checks passed
@github-actions github-actions bot added this to the v4.44.0 milestone Oct 11, 2024
Copy link
Contributor

This functionality has been released in v4.44.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants