Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve llvm build workflow #3

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Improve llvm build workflow #3

merged 1 commit into from
Dec 17, 2024

Conversation

npaun
Copy link
Member

@npaun npaun commented Dec 16, 2024

No description provided.

@npaun npaun requested a review from fhanau December 16, 2024 20:01
@npaun npaun requested a review from a team as a code owner December 16, 2024 20:01
@npaun npaun requested a review from harrishancock December 16, 2024 20:01
@fhanau
Copy link

fhanau commented Dec 16, 2024

Changes themselves LGTM. Something appears to be going wrong with the arm64 Linux binary though: It is 63MB while the amd64 binary is a mere 4.4MB. Based on using bloaty the difference appears to be based on arm64 having debug information available

For compatibility, this should be built on the ubuntu-2022 image – currently the amd64 binary requires glibc 2.36 since ubuntu-latest may resolve to the 24 image, so the binary won't work on older OS versions.

@npaun
Copy link
Member Author

npaun commented Dec 16, 2024

I'm not really sure why only the arm64 executables have debug stuff, but I'll try to get rid of it by adding -g0 and hope it gets rid of it.

@npaun
Copy link
Member Author

npaun commented Dec 16, 2024

@fhanau Should be under control now.

@npaun npaun merged commit d8bce4b into main Dec 17, 2024
5 checks passed
@npaun npaun deleted the npaun/fix-import branch December 17, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants