Make PyodideMetadataReader::getWorkerFiles not fail when it filters files
#3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/fix-get-worker-files
branch
from
88bc14a to
892991d
Compare
dom96
approved these changes
Jan 28, 2025
|
I'll wait until we merge some version of #3415 so that we can get test coverage. |
hoodmane
force-pushed
the
hoodmane/fix-get-worker-files
branch
5 times, most recently
from
feb6985 to
691fdc6
Compare
hoodmane
force-pushed
the
hoodmane/fix-get-worker-files
branch
2 times, most recently
from
78be053 to
f2f6639
Compare
danlapid
approved these changes
Feb 8, 2025
|
Why do so many python tests fail with "EQ was unexpected at this time."? |
|
I dunno it's a pretty small change. It would be strange if it were a real regression... |
…y filters ArrayBuilder assumes the array we are constructing has the exact size given. For constructing variable size arrays, we need a `kj::Vector`
hoodmane
force-pushed
the
hoodmane/fix-get-worker-files
branch
from
f2f6639 to
fce5680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayBuilder assumes the array we are constructing has the exact size given. For constructing variable size arrays, we need a
kj::Vector.