[WIP] Add ncrypto dependency #3463
Draft
+1,406
−345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jasnell/start-adding-ncrypto
branch
3 times, most recently
from
dc7c1a4 to
b1546c4
Compare
anonrig
reviewed
Feb 5, 2025
| auto backing = jsg::BackingStore::alloc<v8::ArrayBuffer>(js, length); | ||
| ncrypto::Buffer<kj::byte> buf(backing.asArrayPtr().begin(), backing.size()); | ||
| ncrypto::Buffer<const char> passbuf{ | ||
| .data = reinterpret_cast<const char*>(pass.begin()), |
There was a problem hiding this comment.
is there a method that just returns const char*? I remember something like asChars().begin()?
Comment on lines
+30
to
+33
| ncrypto::Buffer<const char> buf{ | ||
| .data = reinterpret_cast<const char*>(input.begin()), | ||
| .len = input.size(), | ||
| }; |
There was a problem hiding this comment.
Nit:
Can we just have a conversion function or a static method that converts to ncrypto::Buffer? It seems there are lots of repetitions.
| if (auto bio = ncrypto::ExportPublicKey(buf)) { | ||
| BUF_MEM* bptr = bio; | ||
| auto buf = jsg::BackingStore::alloc(js, bptr->length); | ||
| auto aptr = kj::arrayPtr(bptr->data, bptr->length); |
There was a problem hiding this comment.
Do you need to check for length/emptiness for safety?
| @@ -252,3 +252,8 @@ class CryptoImpl final: public jsg::Object { | |||
| api::node::CryptoImpl::KeyExportOptions, api::node::CryptoImpl::GenerateKeyPairOptions, \ | |||
| api::node::CryptoImpl::CreateAsymmetricKeyOptions, EW_CRYPTO_X509_ISOLATE_TYPES | |||
| } // namespace workerd::api::node | |||
|
|
|||
| // Known todos | |||
There was a problem hiding this comment.
Suggested change
| // Known todos | |
| // TODO(soon): Known todos |
|
|
||
| inline void setToZero() { | ||
| KJ_IF_SOME(backing, maybeBackingStore) { | ||
| memset(backing.asArrayPtr().begin(), 0, backing.size()); |
There was a problem hiding this comment.
I think we should also check for size here before calling memset.
| @@ -208,6 +208,14 @@ class BackingStore { | |||
| return BackingStore(backingStore, byteLength, byteOffset, elementSize, ctor, integerType); | |||
| } | |||
|
|
|||
| template <typename T = v8::Uint8Array> | |||
There was a problem hiding this comment.
Nit:
Any particular reason for not using class?
Suggested change
| template <typename T = v8::Uint8Array> | |
| template <class T = v8::Uint8Array> |
jasnell
force-pushed
the
jasnell/start-adding-ncrypto
branch
from
050b394 to
82287e0
Compare
|
The generated output of |
jasnell
force-pushed
the
jasnell/start-adding-ncrypto
branch
from
82287e0 to
6492b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still very much a work in progress.
This is gonna be a big one.