Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hardcode python_workers_development in certain Py wd-tests. #3477

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Don't hardcode python_workers_development in certain Py wd-tests. #3477

merged 1 commit into from
Feb 6, 2025
+5 −5

Conversation

dom96
Copy link
Collaborator

@dom96 dom96 commented Feb 6, 2025

This is confusing and means these only ever run under one Python version.

@dom96 dom96 requested a review from hoodmane February 6, 2025 11:13
@dom96 dom96 requested review from a team as code owners February 6, 2025 11:13
@dom96 dom96 requested a review from harrishancock February 6, 2025 11:13
@dom96 dom96 mentioned this pull request Feb 6, 2025
Open
hoodmane
hoodmane approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dom96 dom96 merged commit fa2b149 into main Feb 6, 2025
17 of 18 checks passed
@dom96 dom96 deleted the dominik/unhardcode-dev-py-wd-tests branch February 6, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

@harrishancock harrishancock Awaiting requested review from harrishancock harrishancock is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dom96 @hoodmane