Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't embed pyodide-bucket into Python Worker. #3478

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

dom96
Copy link
Collaborator

@dom96 dom96 commented Feb 6, 2025

The pyodide-bucket was only used to get the package URL, but we can hardcode this in metadata.ts instead as it won't be changing.

@dom96 dom96 requested a review from hoodmane February 6, 2025 11:20
@dom96 dom96 requested review from a team as code owners February 6, 2025 11:20
@dom96 dom96 requested a review from ketanhwr February 6, 2025 11:20
@dom96 dom96 force-pushed the dominik/no-embed-pyodide-bucket branch from 07ea0a8 to b5eb4d8 Compare February 6, 2025 11:21
@dom96 dom96 requested a review from a team as a code owner February 6, 2025 11:21
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me aside from a nit.

@dom96 dom96 force-pushed the dominik/no-embed-pyodide-bucket branch from 1193dba to f26d5ed Compare February 6, 2025 16:58
@dom96 dom96 merged commit 18f7bff into main Feb 6, 2025
17 of 18 checks passed
@dom96 dom96 deleted the dominik/no-embed-pyodide-bucket branch February 6, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants