Skip to content

Fix soundness issue in StringBinding::unchecked_from_js_ref #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Fix soundness issue in StringBinding::unchecked_from_js_ref #762

merged 1 commit into from
Jun 24, 2025

Conversation

Vrtgs
Copy link
Contributor

@Vrtgs Vrtgs commented Jun 21, 2025

this may be common, or may not, future refcasting should probably use the ref-cast crate

guybedford
guybedford approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@guybedford guybedford merged commit 5125a44 into cloudflare:main Jun 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vrtgs @guybedford