C3: Don't offer git if username and email unconfigured #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 013c53d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6464640959/npm-package-wrangler-4119You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6464640959/npm-package-wrangler-4119Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6464640959/npm-package-wrangler-4119 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6464640959/npm-package-cloudflare-pages-shared-4119Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
dario-piotrowicz
approved these changes
Oct 5, 2023
petebacondarwin
approved these changes
Oct 8, 2023
petebacondarwin
approved these changes
Oct 10, 2023
| try { | ||
| const userName = await runCommand("git config user.name", { | ||
| useSpinner: false, | ||
| silent: true, | ||
| }); | ||
| if (!userName) return false; | ||
|
|
||
| const email = await runCommand("git config user.name", { | ||
| const email = await runCommand("git config user.email", { |
There was a problem hiding this comment.
Testing - for the win!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3683.
What this PR solves / how to test:
Skips the prompt offering git to c3 users if they haven't yet configured
user.nameanduser.email.Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.