Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump the workerd-and-workers-types group across 1 directory with 2 updates #5752

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 3, 2024

Bumps the workerd-and-workers-types group with 2 updates in the / directory: @cloudflare/workers-types and workerd.

Updates @cloudflare/workers-types from 4.20240419.0 to 4.20240502.0

Commits

Updates workerd from 1.20240419.0 to 1.20240502.0

Release notes

Sourced from workerd's releases.

v1.20240502.0

What's Changed

Full Changelog: cloudflare/workerd@v1.20240423.0...v1.20240502.0

v1.20240423.0

What's Changed

Full Changelog: cloudflare/workerd@v1.20240419.0...v1.20240423.0

Commits
  • 01700a3 Merge pull request #2084 from cloudflare/release-2024-05-02
  • 8849be0 Release 2024-05-02
  • 2a853c8 Fix minor undefined behavior in SchemaFileImpl
  • 2157142 Fix UBSan errors around signed integer overflow and pointer indexing in node ...
  • d72e867 Fix undefined behavior around NaN in io-context.c++
  • 2c11ea1 Fix wrong dynamic type in jsg resource-test
  • 9b385aa Deprecate WritableStream::removeSink (#2064)
  • a2a20a6 Initial implementation of new jsg module registry (#1553)
  • bc590e2 initializing all arrays (#2079)
  • cad5a19 fixing kj::none warnings (#2078)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot requested review from a team as code owners May 3, 2024 10:15
@dependabot dependabot bot added dependencies Used by dependabot to mark PRs as updates to dependencies. miniflare Relating to Miniflare labels May 3, 2024
Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: e540328

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9082710445/npm-package-wrangler-5752

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5752/npm-package-wrangler-5752

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9082710445/npm-package-wrangler-5752 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9082710445/npm-package-create-cloudflare-5752 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9082710445/npm-package-cloudflare-kv-asset-handler-5752
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9082710445/npm-package-miniflare-5752
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9082710445/npm-package-cloudflare-pages-shared-5752
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9082710445/npm-package-cloudflare-vitest-pool-workers-5752

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240419.1
workerd 1.20240502.0 1.20240502.0
workerd --version 1.20240502.0 2024-05-02

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@RamIdeas
Copy link
Contributor

RamIdeas commented May 8, 2024

The workerd version bumped in this PR contains a bug where the AI binding is missing the logs property (the property is no longer used, but it should've been set to an empty array).

The property is to be added back in cloudflare/workerd#2095

The test failures were skipped in #5784 and will be unskipped when the next workerd release (containing cloudflare/workerd#2095) is out

I am questioning whether we should merge this PR as is cc @petebacondarwin

Reason to merge: the bug exists in production right now and so releasing wrangler with this workerd version will allow users to catch this bug before they deploy.
Reasons to wait for next workerd version: avoid causing churn in user's local development workflow

@RamIdeas
Copy link
Contributor

RamIdeas commented May 8, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/workerd-and-workers-types-a3c7f9af3d branch from 200fde2 to f4f8cb0 Compare May 8, 2024 20:12
@RamIdeas
Copy link
Contributor

RamIdeas commented May 9, 2024

We've decided to hold off merging this workerd version into wrangler. We expect the next release to come next week (Monday) and so we can expect it in Wrangler's Tuesday release

@petebacondarwin
Copy link
Contributor

@dependabot recreate

@petebacondarwin petebacondarwin removed the blocked Blocked on other work label May 14, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 14, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@petebacondarwin
Copy link
Contributor

@dependabot recreate

dependabot bot and others added 2 commits May 14, 2024 15:31
…ory with 2 updates

Bumps the workerd-and-workers-types group with 2 updates in the / directory: [@cloudflare/workers-types](https://github.com/cloudflare/workerd) and [workerd](https://github.com/cloudflare/workerd).


Updates `@cloudflare/workers-types` from 4.20240419.0 to 4.20240502.0
- [Release notes](https://github.com/cloudflare/workerd/releases)
- [Changelog](https://github.com/cloudflare/workerd/blob/main/RELEASE.md)
- [Commits](https://github.com/cloudflare/workerd/commits)

Updates `workerd` from 1.20240419.0 to 1.20240502.0
- [Release notes](https://github.com/cloudflare/workerd/releases)
- [Changelog](https://github.com/cloudflare/workerd/blob/main/RELEASE.md)
- [Commits](cloudflare/workerd@v1.20240419.0...v1.20240502.0)

---
updated-dependencies:
- dependency-name: "@cloudflare/workers-types"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: workerd-and-workers-types
- dependency-name: workerd
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: workerd-and-workers-types
...

Signed-off-by: dependabot[bot] <[email protected]>
The following dependency versions have been updated:

| Dependency                | From          | To            |
| ------------------------- | ------------- | ------------- |
| workerd                   | 1.20240419.0  | 1.20240502.0  |
| @cloudflare/workers-types | ^4.20240419.0 | ^4.20240502.0 |
@petebacondarwin petebacondarwin force-pushed the dependabot/npm_and_yarn/workerd-and-workers-types-a3c7f9af3d branch from eb2b8b8 to e540328 Compare May 14, 2024 14:31
@petebacondarwin
Copy link
Contributor

@dependabot close

Copy link
Contributor Author

dependabot bot commented on behalf of github May 14, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@petebacondarwin petebacondarwin deleted the dependabot/npm_and_yarn/workerd-and-workers-types-a3c7f9af3d branch May 14, 2024 14:47
@petebacondarwin
Copy link
Contributor

@dependabot reopen

@petebacondarwin
Copy link
Contributor

😢

@dependabot dependabot bot reopened this May 14, 2024
@dependabot dependabot bot restored the dependabot/npm_and_yarn/workerd-and-workers-types-a3c7f9af3d branch May 14, 2024 16:16
@dependabot dependabot bot closed this May 14, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 14, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/workerd-and-workers-types-a3c7f9af3d branch May 14, 2024 16:19
Copy link
Contributor Author

dependabot bot commented on behalf of github May 14, 2024

Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use @dependabot reopen if the branch has been deleted).

1 similar comment
Copy link
Contributor Author

dependabot bot commented on behalf of github May 14, 2024

Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use @dependabot reopen if the branch has been deleted).

@petebacondarwin
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot reopened this Jun 12, 2024
@dependabot dependabot bot restored the dependabot/npm_and_yarn/workerd-and-workers-types-a3c7f9af3d branch June 12, 2024 18:26
@petebacondarwin
Copy link
Contributor

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 12, 2024

Looks like these dependencies are no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Jun 12, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/workerd-and-workers-types-a3c7f9af3d branch June 12, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Used by dependabot to mark PRs as updates to dependencies. miniflare Relating to Miniflare
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants