-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce the number of parallel file reads on Windows to avoid EMFILE type errors #6009
Conversation
🦋 Changeset detectedLatest commit: f919908 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-wrangler-6009 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6009/npm-package-wrangler-6009 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-wrangler-6009 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-create-cloudflare-6009 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-cloudflare-kv-asset-handler-6009 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-miniflare-6009 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-cloudflare-pages-shared-6009 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9488330209/npm-package-cloudflare-vitest-pool-workers-6009 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
1935fe6
to
aef1ce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -0,0 +1,8 @@ | |||
export function* createBatches<T>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this needs to be a generator rather than a standard function returning an array?
aef1ce0
to
498470d
Compare
Congratulations @RamIdeas, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxc80u4s12320cl7w3k99jbv This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
What this PR solves / how to test
Reapplies the batching reverted in #6002 but with a tested helper method to ensure batches are correctly compiled
Author has addressed the following