Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add checks of uploads of very large number of Pages assets #6010

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Jun 11, 2024

What this PR solves / how to test

Adds a test to avoid accidentally breaking Pages uploads for large numbers of assets.

This test would have failed after the #5632 change.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: just a new non-e2e test added
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: just adding a test
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: just adding a test

Copy link

changeset-bot bot commented Jun 11, 2024

⚠️ No Changeset found

Latest commit: ea441c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petebacondarwin petebacondarwin marked this pull request as ready for review June 11, 2024 20:37
@petebacondarwin petebacondarwin requested review from a team as code owners June 11, 2024 20:37
Copy link
Contributor

github-actions bot commented Jun 11, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-wrangler-6010

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6010/npm-package-wrangler-6010

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-wrangler-6010 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-create-cloudflare-6010 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-cloudflare-kv-asset-handler-6010
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-miniflare-6010
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-cloudflare-pages-shared-6010
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-cloudflare-vitest-pool-workers-6010

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240605.0
workerd 1.20240605.0 1.20240605.0
workerd --version 1.20240605.0 2024-06-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 12, 2024
Copy link

holopin-bot bot commented Jun 12, 2024

Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxbju6d114510cmhpngtze5u

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@GregBrimble
Copy link
Member

Now we have the bot installed, I'm just testing Holopin really quickly here, sorry! Don't mind me!

{ status: 200 }
);
}),
http.post<never, UploadPayloadFile[]>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how many times do we expect this endpoint to be called? should we assert that as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other tests that check how the bucketing works and exactly what requests are made.
This test is purely looking at whether the correct number of assets arrive at the server or not.

@petebacondarwin petebacondarwin merged commit 874da0e into main Jun 12, 2024
19 checks passed
@petebacondarwin petebacondarwin deleted the add-large-upload-test branch June 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants