-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add checks of uploads of very large number of Pages assets #6010
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-wrangler-6010 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6010/npm-package-wrangler-6010 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-wrangler-6010 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-create-cloudflare-6010 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-cloudflare-kv-asset-handler-6010 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-miniflare-6010 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-cloudflare-pages-shared-6010 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9484220166/npm-package-cloudflare-vitest-pool-workers-6010 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxbju6d114510cmhpngtze5u This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Now we have the bot installed, I'm just testing Holopin really quickly here, sorry! Don't mind me! |
697be33
to
ea441c2
Compare
{ status: 200 } | ||
); | ||
}), | ||
http.post<never, UploadPayloadFile[]>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how many times do we expect this endpoint to be called? should we assert that as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other tests that check how the bucketing works and exactly what requests are made.
This test is purely looking at whether the correct number of assets arrive at the server or not.
What this PR solves / how to test
Adds a test to avoid accidentally breaking Pages uploads for large numbers of assets.
This test would have failed after the #5632 change.
Author has addressed the following