Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix typos in C3 E2E actions #6014

Merged
merged 1 commit into from
Jun 12, 2024
Merged

ci: fix typos in C3 E2E actions #6014

merged 1 commit into from
Jun 12, 2024

Conversation

petebacondarwin
Copy link
Contributor

It is possible that because of this we were not testing C3 against yarn!

@petebacondarwin petebacondarwin requested a review from a team as a code owner June 12, 2024 10:06
Copy link

changeset-bot bot commented Jun 12, 2024

⚠️ No Changeset found

Latest commit: 18da0e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 12, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9487169234/npm-package-wrangler-6014

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6014/npm-package-wrangler-6014

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9487169234/npm-package-wrangler-6014 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9487169234/npm-package-create-cloudflare-6014 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9487169234/npm-package-cloudflare-kv-asset-handler-6014
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9487169234/npm-package-miniflare-6014
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9487169234/npm-package-cloudflare-pages-shared-6014
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9487169234/npm-package-cloudflare-vitest-pool-workers-6014

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240605.0
workerd 1.20240605.0 1.20240605.0
workerd --version 1.20240605.0 2024-06-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@@ -49,7 +49,7 @@ jobs:
{ name: npm, version: "0.0.0" },
{ name: pnpm, version: "9.1.3" },
{ name: bun, version: "1.0.3" },
{ name: yarn, verison: "1.0.0" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@petebacondarwin petebacondarwin merged commit 8293ab5 into main Jun 12, 2024
19 checks passed
@petebacondarwin petebacondarwin deleted the fix-action-typos branch June 12, 2024 18:37
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 12, 2024
Copy link

holopin-bot bot commented Jun 12, 2024

Congratulations @petebacondarwin, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxc6czwe105190cmcyarnih8a

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants