fix: avoid esbuild warning when running dev/bundle #6043
Conversation
I've been experimenting with esbuild 0.21.4 with wrangler. It's mostly been fine. But I get this warning every time
```
▲ [WARNING] Import "__INJECT_FOR_TESTING_WRANGLER_MIDDLEWARE__" will always be undefined because there is no matching export in "src/index.ts" [import-is-undefined]
.wrangler/tmp/bundle-Z3YXTd/middleware-insertion-facade.js:8:23:
8 │ .....(OTHER_EXPORTS.__INJECT_FOR_TESTING_WRANGLER_MIDDLEWARE__ ?? []),
╵
```
This is because [email protected] enabled a warning by default whenever an undefined import is accessed on an imports object. However we abuse imports to inject stuff in `middleware.test.ts`. A simple fix is to only inject that code in tests.
🦋 Changeset detectedLatest commit: 4d9dd57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -68,7 +68,7 @@ export async function applyMiddlewareLoaderFacade( | |||
| export * from "${prepareFilePath(entry.file)}"; | |||
|
|
|||
| export const __INTERNAL_WRANGLER_MIDDLEWARE__ = [ | |||
| ...(OTHER_EXPORTS.__INJECT_FOR_TESTING_WRANGLER_MIDDLEWARE__ ?? []), | |||
| ${process.env.NODE_ENV === "test" ? `...(OTHER_EXPORTS.__INJECT_FOR_TESTING_WRANGLER_MIDDLEWARE__ ?? []),` : ""} | |||
There was a problem hiding this comment.
Does Vitest set this?
There was a problem hiding this comment.
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9519135628/npm-package-wrangler-6043You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6043/npm-package-wrangler-6043Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9519135628/npm-package-wrangler-6043 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9519135628/npm-package-create-cloudflare-6043 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9519135628/npm-package-cloudflare-kv-asset-handler-6043npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9519135628/npm-package-miniflare-6043npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9519135628/npm-package-cloudflare-pages-shared-6043npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9519135628/npm-package-cloudflare-vitest-pool-workers-6043Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
workers-devprod
added
the
contribution
|
Congratulations @threepointone, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clxez4jka49160el2effqa3gt This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
(Another simpler take on #5999, inspired by #6006)
I've been experimenting with esbuild 0.21.4 with wrangler. It's mostly been fine. But I get this warning every time
This is because [email protected] enabled a warning by default whenever an undefined import is accessed on an imports object. However we abuse imports to inject stuff in
middleware.test.ts. A simple fix is to only inject that code in tests.