chore: update to turbo v2 #6083

threepointone · 2024-06-19T07:19:50Z

Updates to turbo v2.

Author has addressed the following

Tests
- TODO (before merge)
- Included
- Not necessary because: no functional changes
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required / Maybe required
- Not required because: already covered
Changeset (Changeset guidelines)
- TODO (before merge)
- Included
- Not necessary because: no functional change
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Not necessary because: chore

changeset-bot · 2024-06-19T07:19:55Z

⚠️ No Changeset found

Latest commit: 10686b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-06-19T07:23:00Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9583693363/npm-package-wrangler-6083

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6083/npm-package-wrangler-6083

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9583693363/npm-package-wrangler-6083 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9583693363/npm-package-create-cloudflare-6083 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9583693363/npm-package-cloudflare-kv-asset-handler-6083

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9583693363/npm-package-miniflare-6083

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9583693363/npm-package-cloudflare-pages-shared-6083

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9583693363/npm-package-cloudflare-vitest-pool-workers-6083

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20240610.1
`workerd`	1.20240610.1	1.20240610.1
`workerd --version`	1.20240610.1	2024-06-10

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

threepointone · 2024-06-19T09:24:58Z

packages/create-cloudflare/turbo.json

 		"build": {
-			"env": ["TEST_PM", "TEST_PM_VERSION", "npm_config_user_agent", "CI"],
+			"env": [
+				"TMPDIR",


turbo needs you to whitelist any nv vars that you'd use. We have to add these new ones so that os.tmpdir() works correctly (which depend on them)

threepointone · 2024-06-19T09:25:44Z

packages/miniflare/turbo.json

 		"build": {
 			"inputs": ["src/**", "scripts/**", "types/**", "*.mjs", "*.js", "*.json"],
 			"outputs": ["dist/**", "bootstrap.js", "worker-metafiles/**"],
-			"env": ["CI_OS"]
+			"env": ["CI_OS", "NODE_EXTRA_CA_CERTS"]


without this, the miniflare test Miniflare: HTTPS fetches using browser CA certificates will fail

petebacondarwin

A couple of concerns that need resolving (either by fixing or telling me I'm wrong).

petebacondarwin · 2024-06-19T12:37:35Z

packages/wrangler/turbo.json

+				"NODE_EXTRA_CA_CERTS",
+				"CLOUDFLARE_ACCOUNT_ID",
+				"SOURCEMAPS",
+				"NODE_ENV",
+				"SPARROW_SOURCE_KEY",
+				"ALGOLIA_APP_ID",
+				"ALGOLIA_PUBLIC_KEY",
+				"NO_SCRIPT_SIZE_WARNING",
+				"CLOUDFLARE_API_TOKEN",
+				"CLOUDFLARE_ACCOUNT_ID",
+				"WRANGLER_AUTH_DOMAIN",
+				"PATH",
+				"WRANGLER_LOG",
+				"EXPERIMENTAL_MIDDLEWARE",
+				"FORMAT_WRANGLER_ERRORS",
+				"CF_PAGES",
+				"CI",
+				"CF_PAGES_UPLOAD_JWT",
+				"NO_SCRIPT_SIZE_WARNING",
+				"EXPERIMENTAL_MIDDLEWARE",
+				"NO_D1_WARNING",
+				"NO_HYPERDRIVE_WARNING",
+				"WRANGLER",
+				"WRANGLER_IMPORT",
+				"CUSTOM_BUILD_VAR",
+				"PWD",
+				"LC_ALL",
+				"WRANGLER_SEND_METRICS",
+				"https_proxy",
+				"HTTPS_PROXY",
+				"http_proxy",
+				"HTTP_PROXY",
+				"CI_OS",
+				"SENTRY_DSN",
+				"SYSTEMROOT",


All these feel unnecessary. If they are only in the source files then they are already covered by the build task. Here we should only be declaring the env vars that are referenced in the input files (i.e. "e2e/**").

Similarly for the test:ci above.

If they're read dynamically, then they have to be whitelisted. I considered being more precise, but that would make this more confusing for the future. Instead, I duplicate them across tasks because it's easier to make changes in the future too (where the instruction will be "hey just add it to both"

packages/wrangler/turbo.json

petebacondarwin · 2024-06-19T12:39:52Z

packages/miniflare/turbo.json

 		},
 		"test:ci": {
 			"inputs": ["test/**"],
-			"dependsOn": ["build"]
+			"dependsOn": ["build"],
+			"env": ["CI_OS", "NODE_EXTRA_CA_CERTS"]


Necessary? This should be covered by the build task?

the test runner reads it dynamically, and it has to be whitelisted here for it to be added to the environment

petebacondarwin · 2024-06-19T12:42:47Z

packages/cli/turbo.json

+		"build": {
+			"outputs": ["dist/**"]
+		}


Does overriding this here also override the dependsOn field at the top level?
Do we need to include that?
I see that this package depends upon the eslint and tsconfig packages, so we need those deps marked in turbo so that we don't fail to rebuild this package when those change.

I thin kI can just remove this one, I can't recollect why I put it here at all.

I guess it improves the upstream tasks that rely upon this task?

penalosa · 2024-11-05T18:23:00Z

Apologies, completely missed this PR, and did this separately in #7076

threepointone requested review from a team as code owners June 19, 2024 07:19

threepointone force-pushed the update-turbo-v2 branch from 7ed217f to cb23bfc Compare June 19, 2024 07:32

threepointone marked this pull request as draft June 19, 2024 07:58

threepointone force-pushed the update-turbo-v2 branch 4 times, most recently from d626d6b to bc584bb Compare June 19, 2024 08:48

threepointone added the e2e Run e2e tests on a PR label Jun 19, 2024

threepointone force-pushed the update-turbo-v2 branch 2 times, most recently from 1a5340f to ff2e3bb Compare June 19, 2024 09:26

threepointone marked this pull request as ready for review June 19, 2024 09:26

threepointone commented Jun 19, 2024

View reviewed changes

threepointone force-pushed the update-turbo-v2 branch from ff2e3bb to 48b02b4 Compare June 19, 2024 10:30

petebacondarwin requested changes Jun 19, 2024

View reviewed changes

threepointone force-pushed the update-turbo-v2 branch from 48b02b4 to b203da0 Compare June 19, 2024 12:50

update to turbo v2

10686b5

threepointone force-pushed the update-turbo-v2 branch from b203da0 to 10686b5 Compare June 19, 2024 14:20

penalosa closed this Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update to turbo v2 #6083

chore: update to turbo v2 #6083

threepointone commented Jun 19, 2024 •

edited

Loading

changeset-bot bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

threepointone Jun 19, 2024

threepointone Jun 19, 2024

petebacondarwin left a comment

petebacondarwin Jun 19, 2024

petebacondarwin Jun 19, 2024

threepointone Jun 19, 2024

petebacondarwin Jun 19, 2024

threepointone Jun 19, 2024

petebacondarwin Jun 19, 2024

threepointone Jun 19, 2024

petebacondarwin Jun 19, 2024

penalosa commented Nov 5, 2024 •

edited

Loading

chore: update to turbo v2 #6083

chore: update to turbo v2 #6083

Conversation

threepointone commented Jun 19, 2024 • edited Loading

Author has addressed the following

changeset-bot bot commented Jun 19, 2024 • edited Loading

⚠️ No Changeset found

github-actions bot commented Jun 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petebacondarwin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

penalosa commented Nov 5, 2024 • edited Loading

threepointone commented Jun 19, 2024 •

edited

Loading

changeset-bot bot commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024 •

edited

Loading

penalosa commented Nov 5, 2024 •

edited

Loading