Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudchamber curl command #6126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IRCody
Copy link

@IRCody IRCody commented Jun 22, 2024

What this PR solves / how to test

Adds a cloudchamber curl command. Example usage:

wrangler cloudchamber curl /ssh-public-keys

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: I don't believe any of the cloudchamber commands are documented there atm.

@IRCody IRCody requested review from a team as code owners June 22, 2024 00:07
Copy link

changeset-bot bot commented Jun 22, 2024

🦋 Changeset detected

Latest commit: 26f906f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 22, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9744592361/npm-package-wrangler-6126

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6126/npm-package-wrangler-6126

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9744592361/npm-package-wrangler-6126 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9744592361/npm-package-create-cloudflare-6126 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9744592361/npm-package-cloudflare-kv-asset-handler-6126
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9744592361/npm-package-miniflare-6126
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9744592361/npm-package-cloudflare-pages-shared-6126
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9744592361/npm-package-cloudflare-vitest-pool-workers-6126

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240620.0
workerd 1.20240620.1 1.20240620.1
workerd --version 1.20240620.1 2024-06-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@IRCody
Copy link
Author

IRCody commented Jun 28, 2024

The test failures seem to be coming from something unrelated to this change:

  
   FAIL  src/__tests__/sentry.test.ts > sentry > interactive > should hit sentry after reportable error when permission provided
  Error: Snapshot `sentry > interactive > should hit sentry after reportable error when permission provided 3` mismatched```

@threepointone threepointone force-pushed the cloudchamber-curl branch 5 times, most recently from c4745ed to c93e8aa Compare July 1, 2024 12:32
@threepointone
Copy link
Contributor

as you can tell, I've been poking at this PR. Looks like there's an actual failure on windows. I don't have a windows machine, so I'm debugging with CI. I'll keep poking at it.

@threepointone
Copy link
Contributor

I tried debugging, but it's a bit confusing, so I'm going to move away from this, cc @petebacondarwin

@IRCody
Copy link
Author

IRCody commented Jul 2, 2024

as you can tell, I've been poking at this PR. Looks like there's an actual failure on windows. I don't have a windows machine, so I'm debugging with CI. I'll keep poking at it.

I don't see the windows error in the current test failures. I also do not have a windows machine to test on. What errors were showing up there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants