Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add upload duration and sourcemap size to metrics #6194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zebp
Copy link
Contributor

@zebp zebp commented Jul 3, 2024

What this PR solves / how to test

Adds durationMs and sourceMapSize properties to the deploy worker script metrics event as well as sending the event after the deploy request. This PR can be tested by deploying a Worker using wrangler built from this PR and checking internal tools.

Fixes WP-996

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: Other metrics aren't tested in code and can instead be spot checked with internal tools
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: (as far as I can tell) Wrangler metrics aren't publicly documented

@zebp zebp requested a review from a team as a code owner July 3, 2024 15:31
Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 01553f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9811042123/npm-package-wrangler-6194

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6194/npm-package-wrangler-6194

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9811042123/npm-package-wrangler-6194 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9811042123/npm-package-create-cloudflare-6194 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9811042123/npm-package-cloudflare-kv-asset-handler-6194
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9811042123/npm-package-miniflare-6194
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9811042123/npm-package-cloudflare-pages-shared-6194
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9811042123/npm-package-cloudflare-vitest-pool-workers-6194

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240701.0
workerd 1.20240701.0 1.20240701.0
workerd --version 1.20240701.0 2024-07-01

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@zebp zebp force-pushed the zeb/analytics-sourcemaps branch from 35050fc to 9c48ac3 Compare July 5, 2024 16:01
Adds `durationMs` and `sourceMapSize` properties to the `deploy worker script`
metrics event as well as sending the event after the deploy request.
@zebp zebp force-pushed the zeb/analytics-sourcemaps branch from 9c48ac3 to 01553f5 Compare July 5, 2024 16:14
"wrangler": minor
---

Add duration and sourcemap size to upload metrics event
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

None yet

2 participants