[wrangler] fix: make sure getPlatformProxy
's ctx
methods throw illegal invocation errors like workerd
#6199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
in workerd detaching the
waitUntil
andpassThroughOnException
methods from theExecutionContext
object results in them throwing
illegal invocation
errors, such as for example:this PR makes sure that the same behavior is applied to the
ctx
object returned bygetPlatformProxy
To test it simply use the prerelease and try destructuring and calling the methods of the
getPlatformProxy
'sctx
objectAuthor has addressed the following
Note
The same sort of logic would ideally need to be applied to bindings, that however involves the magic proxy so it likely won't be as straightforward as it was here for
ctx
, thus I thought not to cram both in this PR, so I'll try to do the bindings one in a followup PR (see: #6200)