Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Svelte display name to SvelteKit #6565

Closed
wants to merge 1 commit into from
Closed

Conversation

penalosa
Copy link
Contributor

What this PR solves / how to test

Per #3263 (comment), this is what the Svelte team recommends. The Svelte framework template runs create-svelte which scaffolds a SvelteKit project, so this should make it clearer to users what type of project they're actually going to get.

Fixes #3263

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: this doesn;t have any tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: e2e doesn't apply to c3
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

Per #3263 (comment), this is what the Svelte team recommends. The Svelte framework template runs `create-svelte` which scaffolds a SvelteKit project, so this should make it clearer to users what type of project they're actually going to get.
@penalosa penalosa requested review from a team as code owners August 23, 2024 09:37
Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: c71a539

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-wrangler-6565

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6565/npm-package-wrangler-6565

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-wrangler-6565 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-create-cloudflare-6565 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-kv-asset-handler-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-miniflare-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-pages-shared-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-vitest-pool-workers-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-workers-editor-shared-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-workers-shared-6565

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa marked this pull request as draft August 23, 2024 09:45
@penalosa penalosa marked this pull request as draft August 23, 2024 09:45
@dario-piotrowicz dario-piotrowicz mentioned this pull request Oct 28, 2024
9 tasks
@penalosa
Copy link
Contributor Author

penalosa commented Nov 5, 2024

Closing in favour of #7109

@penalosa penalosa closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: C3's Svelte option is really SvelteKit - confusing?
2 participants