Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new_sqlite_classes migration for Durable Objects #6606

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

joshthoward
Copy link
Contributor

@joshthoward joshthoward commented Aug 30, 2024

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: Will release documentation with birthday week announcement. We are still gating access in EWC.
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: Will release documentation with birthday week announcement. We are still gating access in EWC.

Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: 0c38fa3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 30, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-wrangler-6606

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6606/npm-package-wrangler-6606

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-wrangler-6606 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-create-cloudflare-6606 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-kv-asset-handler-6606
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-miniflare-6606
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-pages-shared-6606
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-vitest-pool-workers-6606
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-workers-editor-shared-6606
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-workers-shared-6606

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.1
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@joshthoward joshthoward force-pushed the joshthoward/new_sqlite_classes branch 3 times, most recently from 1dd128d to 08c95f2 Compare September 4, 2024 01:53
@joshthoward joshthoward marked this pull request as ready for review September 4, 2024 02:00
@joshthoward joshthoward requested a review from a team as a code owner September 4, 2024 02:00
@lrapoport-cf lrapoport-cf added the caretaking Priority for caretaking label Sep 4, 2024
@@ -3172,6 +3178,14 @@ const validateMigrations: ValidatorFn = (diagnostics, field, value) => {
"string"
) && valid;

valid =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably we also need to validate that every string in new_sqlite_classes matches an existing durable object name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is validated in EWC. I am copying the existing validation that is present for new_classes so that they have the same behavior.

@joshthoward joshthoward merged commit 5ea86ca into main Sep 5, 2024
26 checks passed
@joshthoward joshthoward deleted the joshthoward/new_sqlite_classes branch September 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caretaking Priority for caretaking
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants