-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new_sqlite_classes migration for Durable Objects #6606
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-wrangler-6606 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6606/npm-package-wrangler-6606 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-wrangler-6606 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-create-cloudflare-6606 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-kv-asset-handler-6606 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-miniflare-6606 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-pages-shared-6606 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-vitest-pool-workers-6606 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-workers-editor-shared-6606 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704378624/npm-package-cloudflare-workers-shared-6606 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
1dd128d
to
08c95f2
Compare
08c95f2
to
5837bd9
Compare
5837bd9
to
0c38fa3
Compare
@@ -3172,6 +3178,14 @@ const validateMigrations: ValidatorFn = (diagnostics, field, value) => { | |||
"string" | |||
) && valid; | |||
|
|||
valid = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably we also need to validate that every string in new_sqlite_classes
matches an existing durable object name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is validated in EWC. I am copying the existing validation that is present for new_classes so that they have the same behavior.
What this PR solves / how to test
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following