-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-op test + check workflow #6682
Conversation
|
86f5210
to
a1d9f02
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-wrangler-6682 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6682/npm-package-wrangler-6682 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-wrangler-6682 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-create-cloudflare-6682 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-kv-asset-handler-6682 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-miniflare-6682 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-pages-shared-6682 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-vitest-pool-workers-6682 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-workers-editor-shared-6682 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-workers-shared-6682 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if both markdown and non-markdown are touched?
Will we end up with two CI jobs with the same name running?
How does that affect the required checks?
Closing in favour of #6770 |
What this PR solves / how to test
Fixes #6685
Reduce wasted CI time by adding no-op workflows for tests and pre-releases that run when a PR only touches markdown files. We need a no-op workflow rather than just skipping the jobs because both tests and pre-releases are required workflows for a PR to be merged.
You can see the result of these changes on this example PR: #6681
Author has addressed the following