Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-op test + check workflow #6682

Closed
wants to merge 4 commits into from

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Sep 11, 2024

What this PR solves / how to test

Fixes #6685

Reduce wasted CI time by adding no-op workflows for tests and pre-releases that run when a PR only touches markdown files. We need a no-op workflow rather than just skipping the jobs because both tests and pre-releases are required workflows for a PR to be merged.

You can see the result of these changes on this example PR: #6681

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: workflows change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: doesn't touch package code
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: no releases should be triggered
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal detail

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: fc12d23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa penalosa force-pushed the penalosa/ci-experiments-no-markdown-checks branch from 86f5210 to a1d9f02 Compare September 11, 2024 23:14
Copy link
Contributor

github-actions bot commented Sep 11, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-wrangler-6682

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6682/npm-package-wrangler-6682

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-wrangler-6682 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-create-cloudflare-6682 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-kv-asset-handler-6682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-miniflare-6682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-pages-shared-6682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-vitest-pool-workers-6682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-workers-editor-shared-6682
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821206001/npm-package-cloudflare-workers-shared-6682

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.2
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa marked this pull request as ready for review September 11, 2024 23:30
@penalosa penalosa requested a review from a team as a code owner September 11, 2024 23:30
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if both markdown and non-markdown are touched?
Will we end up with two CI jobs with the same name running?
How does that affect the required checks?

@penalosa penalosa requested a review from a team as a code owner September 12, 2024 08:53
@penalosa
Copy link
Contributor Author

Closing in favour of #6770

@penalosa penalosa closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

add support for skipping required checks
2 participants