Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #6688

Closed
wants to merge 1 commit into from
Closed

test #6688

wants to merge 1 commit into from

Conversation

emily-shen
Copy link
Contributor

move shared assets code to workers-shared/utils

add asset config to wrangler

add asset config to miniflare

add config binding to asset-worker

add asset config behaviour to AW (this is the big one)

make UW manually handle 404s

add AW tests to new fixture 'asset-config' (wip)

update assets-only fixture (may drop later)

fix drop-trailing-slash logic

html handling tests

pr feedback

fix tests and pr feedback 2

changesets

temporarily remove check for charset=utf-8 in deploy.test.ts

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

move shared assets code to workers-shared/utils

add asset config to wrangler

add asset config to miniflare

add config binding to asset-worker

add asset config behaviour to AW (this is the big one)

make UW manually handle 404s

add AW tests to  new fixture 'asset-config' (wip)

update assets-only fixture (may drop later)

fix drop-trailing-slash logic

html handling tests

pr feedback

fix tests and pr feedback 2

changesets

temporarily remove check for charset=utf-8 in deploy.test.ts
@emily-shen emily-shen requested a review from a team as a code owner September 12, 2024 12:16
Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 96aa47b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/workers-shared Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen closed this Sep 12, 2024
@emily-shen emily-shen deleted the emily/test-asset-config branch September 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant