Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable external-durable-objects-app fixture tests #6689

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

GregBrimble
Copy link
Member

What this PR solves / how to test

They're so flakey.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: disabling tests 🫨
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: disabling tests 🫨
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: internal changes
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal changes

@GregBrimble GregBrimble requested a review from a team as a code owner September 12, 2024 12:19
Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 36ba8af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 12, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830792037/npm-package-wrangler-6689

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6689/npm-package-wrangler-6689

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830792037/npm-package-wrangler-6689 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830792037/npm-package-create-cloudflare-6689 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830792037/npm-package-cloudflare-kv-asset-handler-6689
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830792037/npm-package-miniflare-6689
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830792037/npm-package-cloudflare-pages-shared-6689
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830792037/npm-package-cloudflare-vitest-pool-workers-6689
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830792037/npm-package-cloudflare-workers-editor-shared-6689
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830792037/npm-package-cloudflare-workers-shared-6689

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.2
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble merged commit 1986492 into main Sep 12, 2024
21 checks passed
@GregBrimble GregBrimble deleted the disable-do-fixture-test branch September 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants