Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose sqlite in Vitest #6725

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Expose sqlite in Vitest #6725

merged 5 commits into from
Sep 20, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Sep 16, 2024

What this PR solves / how to test

Fixes N/A

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not covered by e2e
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: This is a bug fix.

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 862a765

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 16, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944072517/npm-package-wrangler-6725

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6725/npm-package-wrangler-6725

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944072517/npm-package-wrangler-6725 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944072517/npm-package-create-cloudflare-6725 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944072517/npm-package-cloudflare-kv-asset-handler-6725
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944072517/npm-package-miniflare-6725
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944072517/npm-package-cloudflare-pages-shared-6725
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944072517/npm-package-cloudflare-vitest-pool-workers-6725
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944072517/npm-package-cloudflare-workers-editor-shared-6725
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944072517/npm-package-cloudflare-workers-shared-6725

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.3
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@joshthoward joshthoward marked this pull request as ready for review September 17, 2024 14:55
@joshthoward joshthoward requested a review from a team as a code owner September 17, 2024 14:55
@penalosa penalosa force-pushed the penalosa/sqlite-in-vitest branch 2 times, most recently from 0ee80a7 to 35181e0 Compare September 19, 2024 15:24
@edmundhung edmundhung merged commit 92730bb into main Sep 20, 2024
22 of 26 checks passed
@edmundhung edmundhung deleted the penalosa/sqlite-in-vitest branch September 20, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants