Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular c3 e2e caching #6729

Closed
wants to merge 2 commits into from
Closed

Conversation

penalosa
Copy link
Contributor

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

Copy link

changeset-bot bot commented Sep 16, 2024

⚠️ No Changeset found

Latest commit: dd685f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 16, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10959096299/npm-package-wrangler-6729

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6729/npm-package-wrangler-6729

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10959096299/npm-package-wrangler-6729 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10959096299/npm-package-create-cloudflare-6729 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10959096299/npm-package-cloudflare-kv-asset-handler-6729
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10959096299/npm-package-miniflare-6729
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10959096299/npm-package-cloudflare-pages-shared-6729
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10959096299/npm-package-cloudflare-vitest-pool-workers-6729
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10959096299/npm-package-cloudflare-workers-editor-shared-6729
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10959096299/npm-package-cloudflare-workers-shared-6729

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.4
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

}

for (const task of tasks.values()) {
execSync(task, {

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
file name
.
@penalosa penalosa force-pushed the penalosa/c3-e2e-granular-caching branch from bcf9a4c to dd685f4 Compare September 20, 2024 12:18
@penalosa penalosa closed this Sep 20, 2024
@penalosa
Copy link
Contributor Author

Closing as the extra overhead from turbo makes this not worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant