Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support non-default build conditions via the WRANGLER_BUILD_CONDITIONS flag #6743

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Sep 17, 2024

What this PR solves / how to test

  • support non-default build conditions via the WRANGLER_BUILD_CONDITIONS flag
  • support setting the build platform via the WRANGLER_BUILD_PLATFORM flag

Fixes #6742

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: fixture covers the behaviour
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal undocumented flag

@petebacondarwin petebacondarwin requested a review from a team as a code owner September 17, 2024 21:05
Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: e024f96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 17, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-wrangler-6743

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6743/npm-package-wrangler-6743

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-wrangler-6743 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-create-cloudflare-6743 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-kv-asset-handler-6743
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-miniflare-6743
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-pages-shared-6743
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-vitest-pool-workers-6743
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-workers-editor-shared-6743
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-workers-shared-6743

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.3
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add WRANGLER_BUILD_PLATFORM to set the platform option for esbuild. This should be set to "node" to prevent the import of browser files. The commerce app would not build without that.

It would be nice to add some links to the relevant docs:

@petebacondarwin
Copy link
Contributor Author

Skipping PR description validation as it is a bit broken 😄

@petebacondarwin petebacondarwin added skip-pr-validation skip-pr-description-validation Skip validation of the required PR description format and removed skip-pr-validation labels Sep 19, 2024
@petebacondarwin petebacondarwin merged commit b45e326 into main Sep 19, 2024
22 checks passed
@petebacondarwin petebacondarwin deleted the add-esbuild-condition-env-var branch September 19, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Some Next.js applications cannot be built because they load the wrong export from 3rd party packages
5 participants