-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support non-default build conditions via the WRANGLER_BUILD_CONDITIONS flag #6743
Conversation
🦋 Changeset detectedLatest commit: e024f96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-wrangler-6743 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6743/npm-package-wrangler-6743 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-wrangler-6743 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-create-cloudflare-6743 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-kv-asset-handler-6743 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-miniflare-6743 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-pages-shared-6743 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-vitest-pool-workers-6743 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-workers-editor-shared-6743 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10940169561/npm-package-cloudflare-workers-shared-6743 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add WRANGLER_BUILD_PLATFORM
to set the platform option for esbuild. This should be set to "node"
to prevent the import of browser files. The commerce app would not build without that.
It would be nice to add some links to the relevant docs:
03d1162
to
d6414da
Compare
Skipping PR description validation as it is a bit broken 😄 |
d6414da
to
9dd6f86
Compare
76043b0
to
ff7fd43
Compare
…LD_CONDITIONS flag
ff7fd43
to
e024f96
Compare
What this PR solves / how to test
Fixes #6742
Author has addressed the following