chore: update actions/upload-artifact to v4

[vicb]

What this PR solves / how to test

Warning in the CI:

https://github.com/actions/upload-artifact says:

Warning

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024. Learn more.
Similarly, v1/v2 are scheduled for deprecation on June 30, 2024.
Please update your workflow to use v4 of the artifact actions.
This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers.

Fixes N/A

Author has addressed the following

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because: CI update
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because:
• Changeset (Changeset guidelines)
  • TODO (before merge)
  • Changeset included
  • Changeset not necessary because: CI dep update
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because: CI dep update

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3a90514

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10957096552/npm-package-wrangler-6784

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6784/npm-package-wrangler-6784

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10957096552/npm-package-wrangler-6784 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10957096552/npm-package-create-cloudflare-6784 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10957096552/npm-package-cloudflare-kv-asset-handler-6784

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10957096552/npm-package-miniflare-6784

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10957096552/npm-package-cloudflare-pages-shared-6784

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10957096552/npm-package-cloudflare-vitest-pool-workers-6784

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10957096552/npm-package-cloudflare-workers-editor-shared-6784

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10957096552/npm-package-cloudflare-workers-shared-6784

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240909.4
workerd	1.20240909.0	1.20240909.0
workerd --version	1.20240909.0	2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[petebacondarwin]

I don't think this is as simple as updating the dependency.
We need the upload and download actions to be in sync, and v3 to v4 is a breaking change that needs a change to how we name and update artifacts.