Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quarantine C3 analog e2e tests #6995

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Oct 16, 2024

What this PR solves / how to test

This PR quarantines the C3 analog e2e tests, which started failing since yesterday. After thoroughly debugging together with Pete, we concluded that the breakage is not caused by one particular change in workers-sdk, but rather due to some changes in analog itself. Specifically, the breakage seems to come from the latest release of analog, aka v 1.9.0. Currently C3 has a dependency on analog ^1.8.0, which ends up pulling 1.9.0, and results in the failures we're seeing. We attempted to fix the version number of our dependency to 1.8.0, but unfortunately that still end up pulling 1.9.0, due to how analog internally declares its dependencies. This is something we don't have control over, which is why we ultimately decided to quarantine these tests.

We also attempted to fix forward, based off of #6975, that bumps create-analog to 1.9.0, but unfortunately that broke other things, so here we are.

These tests should be quarantined until we are either able to successfully bump create-analog to 1.9.0, or until a downstream fix comes from the analog team <3

Fixes N/A.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: e2e test quarantine
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: e2e test quarantine
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: e2e test quarantine

@CarmenPopoviciu CarmenPopoviciu requested review from a team as code owners October 16, 2024 10:50
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: c0e27f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CarmenPopoviciu CarmenPopoviciu added the e2e Run e2e tests on a PR label Oct 16, 2024
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-wrangler-6995

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6995/npm-package-wrangler-6995

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-wrangler-6995 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-create-cloudflare-6995 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-kv-asset-handler-6995
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-miniflare-6995
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-pages-shared-6995
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-vitest-pool-workers-6995
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-workers-editor-shared-6995
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-workers-shared-6995

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241004.0
workerd 1.20241011.1 1.20241011.1
workerd --version 1.20241011.1 2024-10-11

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu
Copy link
Contributor Author

CarmenPopoviciu commented Oct 16, 2024

cc// @brandonroberts FYI

please let me know if any of the above is unclear, or if you have any questions. Also do let me know if there is anything I can support you with, assuming this is smth that can be fixed on the analog side ♥️

@CarmenPopoviciu CarmenPopoviciu merged commit 6d458fc into main Oct 16, 2024
37 of 43 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/quarantine-analog branch October 16, 2024 11:28
@brandonroberts
Copy link

Thanks for the heads up @CarmenPopoviciu. Is C3 using the latest template or still pinned to angular-v17? I think using the --template latest would fix in the install issues, but I will check and see what else can be done to resolve this.

@CarmenPopoviciu
Copy link
Contributor Author

thank you so much @brandonroberts ♥️ !!! From what I could tell, we're still pinned to angular-v17. I think Pete tried to pin to latest but that didn't work? I'll have to check again.

Kepp me posted please if you find anything, or if I can action anything on our side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants