Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Vitest 3 #7923

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Support Vitest 3 #7923

wants to merge 5 commits into from

Conversation

penalosa
Copy link
Contributor

Fixes #7847

Update @cloudflare/vitest-pool-workers to support (and require) Vitest v3. Additionally, support the vitest list API.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: existing tests provide coverage
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

@penalosa penalosa requested a review from a team as a code owner January 27, 2025 14:32
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b3cce96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

penalosa
penalosa commented Jan 27, 2025
View reviewed changes
packages/vitest-pool-workers/src/worker/lib/cloudflare/test-runner.ts Outdated
@@ -209,15 +209,6 @@ export default class WorkersTestRunner extends VitestTestRunner {
initialState.current = this.state.current;
}

async onBeforeRunFiles() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been removed in Vitest v3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit strange that onBeforeRunFiles is removed while we are still using onAfterRunFiles 🤔

Any chance it is a different issue? I can also find onBeforeRunFiles on vitest docs:
https://github.com/vitest-dev/vitest/blob/9acc13f367988ff5711f51d8b360a7f6d6602d2c/docs/advanced/runner.md?plain=1#L69-L76

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still in the docs, but it's been removed from the actual code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/vitest-dev/vitest/blob/9acc13f367988ff5711f51d8b360a7f6d6602d2c/packages/vitest/src/runtime/runners/test.ts

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-wrangler-7923

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7923/npm-package-wrangler-7923

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-wrangler-7923 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-cloudflare-workers-bindings-extension-7923 -O ./cloudflare-workers-bindings-extension.0.0.0-v3a562206b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v3a562206b.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-create-cloudflare-7923 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-cloudflare-kv-asset-handler-7923

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-miniflare-7923

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-cloudflare-pages-shared-7923

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-cloudflare-unenv-preset-7923

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-cloudflare-vite-plugin-7923

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-cloudflare-vitest-pool-workers-7923

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-cloudflare-workers-editor-shared-7923

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-cloudflare-workers-shared-7923

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13056817332/npm-package-cloudflare-workflows-shared-7923

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

edmundhung
edmundhung reviewed Jan 27, 2025
View reviewed changes
packages/vitest-pool-workers/src/worker/lib/cloudflare/test-runner.ts
await scheduler.wait(100);
}

resetMockAgent(fetchMock);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to figure out where to reset the MockAgent if onBeforeRunFiles is removed

@penalosa penalosa requested a review from a team as a code owner January 27, 2025 23:25
@penalosa penalosa requested review from a team as code owners January 28, 2025 14:59
@penalosa penalosa force-pushed the penalosa/vitest-3 branch 2 times, most recently from 73e8855 to 4d0d14b Compare January 30, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundhung edmundhung edmundhung left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Vitest v3 support
2 participants
@penalosa @edmundhung