Skip to content

Commit

Permalink
Tweak the fixture test for the pre-installed-wrangler test
Browse files Browse the repository at this point in the history
  • Loading branch information
petebacondarwin committed May 3, 2024
1 parent 2523489 commit 06f5e60
Show file tree
Hide file tree
Showing 7 changed files with 66 additions and 1,279 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,4 @@ jobs:
uses: ./
with:
workingDirectory: "./test/pre-installed-wrangler"
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
command: deploy --dry-run
command: action-test
45 changes: 25 additions & 20 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,34 +93,39 @@ async function installWrangler() {
["wrangler", "--version"],
{
cwd: config["workingDirectory"],
silent: true,
silent: config.QUIET_MODE,
},
);
const versionMatch = stdout.match(/wrangler (\d+\.\d+\.\d+)/);
if (!versionMatch) {
throw new Error(
`Unable to parse Wrangler version from the output: ${stdout}`,
);
// There are two possible outputs from `wrangler --version`:
// ` ⛅️ wrangler 3.48.0 (update available 3.53.1)`
// and
// `3.48.0`
const versionMatch =
stdout.match(/wrangler (\d+\.\d+\.\d+)/) ??
stdout.match(/^(\d+\.\d+\.\d+)/);
if (versionMatch) {
installedVersion = versionMatch[1];
}
installedVersion = versionMatch[1];
if (config.didUserProvideWranglerVersion) {
if (semverEq(config.WRANGLER_VERSION, installedVersion)) {
info(`✅ Using Wrangler ${installedVersion}`, true);
endGroup();
return;
if (installedVersion) {
if (config.didUserProvideWranglerVersion) {
if (semverEq(config.WRANGLER_VERSION, installedVersion)) {
info(`✅ Using Wrangler ${installedVersion}`, true);
endGroup();
return;
} else {
info(
`Wrangler version ${installedVersion} is not equal to the required version. Installing...`,
true,
);
}
} else {
info(
`Wrangler version ${installedVersion} is not equal to the required version. Installing...`,
`✅ No wrangler version specified, using pre-installed wrangler version ${installedVersion}`,
true,
);
endGroup();
return;
}
} else {
info(
`✅ No wrangler version specified, using pre-installed wrangler version ${installedVersion}`,
true,
);
endGroup();
return;
}
} catch (error) {
debug(`Error checking Wrangler version: ${error}`);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env node
"use strict";

require("../index");
16 changes: 16 additions & 0 deletions test/pre-installed-wrangler/mock_packages/wrangler/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
const args = Array.from(process.argv);
const command = args.pop();
switch (command) {
case "--version":
console.log(
"⛅️ wrangler 1.1.1 (update available 1.2.3)\n" +
"-------------------------------------------------------",
);
process.exit(0);
case "action-test":
console.log("Test successful.");
process.exit(0);
default:
console.error("Invalid command");
process.exit(1);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"private": true,
"name": "wrangler",
"version": "1.1.1",
"main": "index.js",
"bin": "bin/wrangler"
}
Loading

0 comments on commit 06f5e60

Please sign in to comment.