Skip to content

Commit

Permalink
bump test timeouts from 10s to 60s
Browse files Browse the repository at this point in the history
Apparently our concourse workers need more time. We were able to run the test successfully, and also Keiss hijacked into a container, focused and bumped the timeout of a single test and it passed.

Signed-off-by: Aram Price <[email protected]>
  • Loading branch information
mingxiao authored and aramprice committed Jul 22, 2024
1 parent 84824c0 commit 5cd6767
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions s3-config-validator/src/test/binary/binary_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ var _ = Describe("binary tests", func() {

Context("is not valid", func() {
It("fails with an error message", func() {
Eventually(session, "10s").Should(gexec.Exit(1))
Eventually(session, "60s").Should(gexec.Exit(1))
Eventually(session.Out).Should(gbytes.Say(`Bad config`))
})
})
Expand Down Expand Up @@ -166,7 +166,7 @@ var _ = Describe("binary tests", func() {
})

It("displays general information", func() {
Eventually(session, "10s").Should(gexec.Exit(0))
Eventually(session, "60s").Should(gexec.Exit(0))
Expect(string(session.Out.Contents())).To(ContainSubstring(dedent(`
Make sure to run this on your 'backup & restore' VM.
Expand All @@ -182,7 +182,7 @@ var _ = Describe("binary tests", func() {
It("successfully validates just read-only operations", func() {
session := executeBBRValidatorUnversioned(validUnversionedConfigFile.Name())

Eventually(session, "10s").Should(gexec.Exit(0))
Eventually(session, "60s").Should(gexec.Exit(0))
Expect(string(session.Out.Contents())).To(ContainSubstring(dedent(`
Validating test-resource's live bucket bbr-s3-validator-e2e-all-permissions ...
* Bucket is not versioned ... Yes
Expand All @@ -208,7 +208,7 @@ var _ = Describe("binary tests", func() {
})

It("displays general information", func() {
Eventually(session, "10s").Should(gexec.Exit(0))
Eventually(session, "60s").Should(gexec.Exit(0))
Expect(string(session.Out.Contents())).To(ContainSubstring(dedent(`
Make sure to run this on your 'backup & restore' VM.
Expand All @@ -222,7 +222,7 @@ var _ = Describe("binary tests", func() {
})

It("successfully validates all operations", func() {
Eventually(session, "10s").Should(gexec.Exit(0))
Eventually(session, "60s").Should(gexec.Exit(0))
Expect(string(session.Out.Contents())).To(ContainSubstring(dedent(`
Validating test-resource's live bucket bbr-s3-validator-e2e-all-permissions ...
* Bucket is not versioned ... Yes
Expand Down Expand Up @@ -250,7 +250,7 @@ var _ = Describe("binary tests", func() {
})

It("Displays the usage", func() {
Eventually(session, "10s").Should(gexec.Exit(0))
Eventually(session, "60s").Should(gexec.Exit(0))
Expect(string(session.Out.Contents())).To(ContainSubstring(dedent(`
Validates a BOSH backup and restore bucket configuration.
By default it will assume versioned buckets unless specified otherwise.
Expand Down

0 comments on commit 5cd6767

Please sign in to comment.