Remove validation preventing both name and os for stemcells. #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Although those changes worked for full deploys, the way that manifests get parsed when doing things such as recreates causes the jobs to trip over the "cannot specify both name and os for stemcell" validation. It would probably be possible to find some way to work around this, but the validation just isn't very useful anyway. This commit removes that validation, making it valid now to specify both name and os. When both are specified, name is given priority and os is ignored (as name has the os included in it anyway). It is now possible to make an invalid manifest, where the name and os don't actually match, but it will deploy anyway as long as the name is valid. This doesn't seem like a compelling reason to keep this validation around.
jpalermo
force-pushed
the
pr-remove-stemcell-name-and-os-validation
branch
from
6e9af42 to
296ade2
Compare
beyhan
approved these changes
Jan 9, 2024
lnguyen
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2484, which broke everything...
Although those changes worked for full deploys, the way that manifests get parsed when doing things such as recreates causes the jobs to trip over the "cannot specify both name and os for stemcell" validation.
It would probably be possible to find some way to work around this, but the validation just isn't very useful anyway.
This commit removes that validation, making it valid now to specify both name and os.
When both are specified, name is given priority and os is ignored (as name has the os included in it anyway). It is now possible to make an invalid manifest, where the name and os don't actually match, but it will deploy anyway as long as the name is valid. This doesn't seem like a compelling reason to keep this validation around.