Use post_bbr_healthcheck_timeout_in_seconds for backup and restore #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unlock - post-start waits for server to become healthy with api_post_start_healthcheck_timeout_in_seconds, so consistent now across post-backup and post-restore - still uses default of 60 seconds - user can expect the same time now Authored-by: Michael Oleske <[email protected]>
|
Since the findings in #230 indicated that |
|
I was wondering that as well, which is why I left it in draft mode. I'll go make another commit with a new config parameter |
- based on feedback, don't use the post start since that doesn't actually affect other start up scripts Authored-by: Michael Oleske <[email protected]>
|
If someone has thoughts on tests that should be added let me know. Will take a look to see if something makes sense but probably not since it just passes this value to the script |
moleske
changed the title
sethboyles
approved these changes
Apr 4, 2022
moleske
deleted the
bbr-use-api_post_start_healthcheck_timeout_in_seconds
branch
will-gant
pushed a commit
to sap-contributions/capi-release
that referenced
this pull request
May 19, 2022
…loudfoundry#235) * Use post_bbr_healthcheck_timeout_in_seconds for backup and restore unlock - still uses default of 60 seconds Authored-by: Michael Oleske <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unlock
api_post_start_healthcheck_timeout_in_seconds, so consistent now
across post-backup and post-restore
Authored-by: Michael Oleske [email protected]
Thanks for contributing to the
capi_release. To speed up the process of reviewing your pull request please provide us with:A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite