Skip to content

Commit

Permalink
chore: use Go 1.24 tool feature for Ginkgo (#1188)
Browse files Browse the repository at this point in the history
  • Loading branch information
blgm authored Feb 13, 2025
1 parent 3fc2184 commit bc682d5
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/focused-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ jobs:
with:
go-version: '1.24.0'
- uses: actions/checkout@v4
- run: go run github.com/onsi/ginkgo/v2/ginkgo unfocus && test -z "$(git status -s)"
- run: go tool ginkgo unfocus && test -z "$(git status -s)"

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ test-units: ## run unit tests
# Integration tests are relatively resource-hungry, so we tune down the number of processes that run in parallel
.PHONY: test-integration
test-integration: .pak-cache ## run integration tests
PAK_BUILD_CACHE_PATH=$(PAK_CACHE) go run github.com/onsi/ginkgo/v2/ginkgo --procs 4 integrationtest/...
PAK_BUILD_CACHE_PATH=$(PAK_CACHE) go tool ginkgo --procs 4 integrationtest/...

.pak-cache:
mkdir -p $(PAK_CACHE)
Expand Down
2 changes: 2 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -142,3 +142,5 @@ require (
gopkg.in/ini.v1 v1.67.0 // indirect
rsc.io/goversion v1.2.0 // indirect
)

tool github.com/onsi/ginkgo/v2/ginkgo
1 change: 0 additions & 1 deletion tools/tools.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package tools
import (
_ "github.com/google/gops"
_ "github.com/maxbrunsfeld/counterfeiter/v6"
_ "github.com/onsi/ginkgo/v2/ginkgo"
_ "golang.org/x/tools/cmd/goimports"
_ "honnef.co/go/tools/cmd/staticcheck"
)
Expand Down

0 comments on commit bc682d5

Please sign in to comment.